[HECnet] New bridge.c feedback

[Boyanich, Alastair]

Ah.. newer version available. 

Actually.. I think I'm about 50+ emails behind -CURRENT on the list ..
I'll go read through them first and catch up.

Al.

-----Original Message-----
From: owner-hecnet at Update.UU.SE [mailto:owner-hecnet at Update.UU.SE] On
Behalf Of Johnny Billquist
Sent: Thursday, 7 June 2012 6:11 PM
To: hecnet at Update.UU.SE
Subject: Re: [HECnet] New bridge.c feedback

On 2012-06-07 09:42, Johnny Billquist wrote:
Hi, Alastair. Thanks for the feedback. Interesting... Care to help
me
figure some things out...?

On 2012-06-07 08:33, Boyanich, Alastair wrote:
cc-1171 cc: WARNING File = bridge.c, Line = 684
The indicated expression has no effect.

if (port == 0) port == DPORT;
^

Blech! Well, DPORT is by default set to 0. See the documentation of
the
define in the sources... This one will stay.

Oh well. I made a conditional around this, so that if people don't
change DPORT, it will not even be compiled. Warning gone...

Cleaned up the code some, based on inspiration fallout here. New
version
available. No functional changes...

	Johnny