[HECnet] New bridge.c feedback

[Boyanich, Alastair]

Hi Johnny,

Yes. It seems to want <strings.h> 6.5.24 and above (or 6.5.29f in my
case) was aiming at SUSv3 compliance away from base XPG4 so things were
moved to strings.h
(http://pubs.opengroup.org/onlinepubs/009695399/functions/index.html) ..
it's also in the 3c index man page, you were right. 

So, compiles on IRIX 6.5.29 if the header is included. Worth gating it
in via #ifdef ? I'm also a fan of enum types. Binary emitted is ~298kb.

Also, your welcome to an account on the system if you wish to poke/play
around, it's accessible over ssh and the general internet (it's my daily
shell/hacking on code box).

-Wall makes the MIPSpro runtime *extremely* chatty. It's quite anal. See
below.

Al.


cc-3201 cc: REMARK File = bridge.c, Line = 158
  The parameter "data" was never referenced.

  int lookup(struct sockaddr_in *sa, char *data)
                                                                                    ^

cc-1506 cc: REMARK File = bridge.c, Line = 460
  There is an implicit conversion from "unsigned long" to "long";
rounding, sign
                  extension, or loss of accuracy may result.

      delta = timedelta(bridge[index].lasttime);
                      ^

cc-3201 cc: REMARK File = bridge.c, Line = 559
  The parameter "r" was never referenced.

  void dump_nomatch(struct sockaddr_in *r, struct DATA *d)
                                                                              ^

cc-3201 cc: REMARK File = bridge.c, Line = 559
  The parameter "d" was never referenced.

  void dump_nomatch(struct sockaddr_in *r, struct DATA *d)
                                                                                                              ^

cc-1185 cc: WARNING File = bridge.c, Line = 579
  An enumerated type is mixed with another type.

      d->type = classify_packet(d);
                      ^

cc-1171 cc: WARNING File = bridge.c, Line = 685
  The indicated expression has no effect.

      if (port == 0) port == DPORT;
                                    ^

cc-1498 cc: REMARK File = bridge.c, Line = 709
  There is no prototype for the call to read_conf.

      read_conf();
      ^

cc-1209 cc: REMARK File = bridge.c, Line = 715
  The controlling expression is constant.

      while(1) {
                  ^
jazz:~/src/HECnet[436]%